limit of 1024 chars in ParameterString

Discussion about the Bidule SDK, post your questions, feature request and plugins here.

Moderators: davidv, seb@plogue

dts350z
Posts: 1521
Joined: Thu Jan 15, 2009 1:18 pm

limit of 1024 chars in ParameterString

Postby dts350z » Mon Dec 21, 2009 11:24 pm

in BiduleSDK.h

Code: Select all

struct ParameterString {char defaultValue[1024]; //TODO: this means no textarea!?!
      };


Any reason I shouldn't change this hard coded default to something larger?

I want to use a text area box to paste in cue files.

haven't actually counted the characters in a typical cue file but 1024 sounds pretty low.

seb@plogue
Site Admin
Posts: 9592
Joined: Tue Mar 02, 2004 7:23 pm
Location: Montreal
Contact:

Postby seb@plogue » Tue Dec 22, 2009 9:51 am

Any reason I shouldn't change this hard coded default to something larger?


Because the header file is also used when compiling Bidule and changing anything in there is asking for troubles...

The only solution would be to add a new parameter type which doesn't use the paramInfo union in ParameterInfo but some new opcodes so that this doesn't break any existing plug-ins.

[edit]
ok, it might simply need changing the char array size in getParameterValue/updateParameter in the base class and not a new parameter type unless you wish to have a very long default value.
[/edit]

dts350z
Posts: 1521
Joined: Thu Jan 15, 2009 1:18 pm

Postby dts350z » Tue Dec 22, 2009 11:38 am

seb@plogue wrote:
Any reason I shouldn't change this hard coded default to something larger?


Because the header file is also used when compiling Bidule and changing anything in there is asking for troubles...

The only solution would be to add a new parameter type which doesn't use the paramInfo union in ParameterInfo but some new opcodes so that this doesn't break any existing plug-ins.

[edit]
ok, it might simply need changing the char array size in getParameterValue/updateParameter in the base class and not a new parameter type unless you wish to have a very long default value.
[/edit]


OK I see where you are referring to. Would 4096 be OK?

seb@plogue
Site Admin
Posts: 9592
Joined: Tue Mar 02, 2004 7:23 pm
Location: Montreal
Contact:

Postby seb@plogue » Tue Dec 22, 2009 11:44 am

OK I see where you are referring to. Would 4096 be OK?


It should be unless the cue files are bigger than that.


Return to “Bidule SDK”

Who is online

Users browsing this forum: No registered users and 2 guests